Last active
March 2, 2018 11:30
-
-
Save backflip/eace9536f147638c647fbfcaf203ff51 to your computer and use it in GitHub Desktop.
PR checklist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary | |
*What is happening here?* | |
*Link to preview* | |
### Checklist | |
*Is the new code consistent with the existing one?* | |
*Was existing code used or adapted where possible in order to prevent duplicating similar functionality?* | |
*Does the solution work in a different context and with different content? Will it still work and look as intended when placed in a different container? Will it still work with longer/shorter content?* | |
*Does the code follow our coding conventions?* | |
*Is the code properly documented? Will other frontend engineers working with the source be able to understand it? Will backend engineers be able to implement the build with the information provided?* | |
*Are assumptions properly documented (i.e. necessary due to a lack of specification)?* | |
*Which browsers were tested?* | |
*Was accessibility tested? If so: How and where?* | |
### Questions or special instructions for the reviewers | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment