Created
February 10, 2016 20:33
-
-
Save cfjedimaster/ab78eb3e0adbef982098 to your computer and use it in GitHub Desktop.
Ionic v2 doc issues
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) http://ionicframework.com/docs/v2/getting-started/tutorial/project-structure/ | |
Template URL in code sample shows | |
templateUrl: 'app/app.html' | |
but it should be build/app.html | |
2) Same url. app.html source code does not match latest code in tutorial sample. I think it is just missing this: | |
id="leftMenu" | |
3) Same url, this text: | |
"In this template, we set up an ion-menu to function as a side menu, and then a navigation controller" | |
has a <br> added at the end which breaks the layout slightly. I see this on the next tutorial page too, so perhaps the same issue. | |
4) This page, http://ionicframework.com/docs/v2/getting-started/tutorial/adding-pages/, first code block does not match what is in the source code. | |
5) Same URL, " Inside the app/hello-ionic/" that folder doesn't exist. Missing "pages/" I believe. | |
6) Same URL, code for hello-ionic.js doesn't match latest. | |
Also, the text right after it, "Note that we pass in the nav object, and set it as a property in the constructor." is incorrect since nav isn't being passed at all. | |
7) Same URL, hello-ionic.html source does not match latest. | |
8) Same URL, list.js source doesn't match - both in header and itemTapped | |
That also makes this text, "Notice that we are also defining an itemTapped function that logs the title of an item to the console.", incorrect. | |
9) Same URL, list.html is wrong too | |
10) http://ionicframework.com/docs/v2/getting-started/tutorial/navigation/ | |
Text is wrong since itemTapped doesn't match | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment