Last active
September 14, 2020 22:03
-
-
Save incognitojam/0ca48df2282b57160faf4c3157084bdd to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt | |
index 9c05c1fd8..426e87a8e 100644 | |
--- a/Documentation/admin-guide/kernel-parameters.txt | |
+++ b/Documentation/admin-guide/kernel-parameters.txt | |
@@ -3434,6 +3434,14 @@ | |
Also, it enforces the PCI Local Bus spec | |
rule that those bits should be 0 in system reset | |
events (useful for kexec/kdump cases). | |
+ pcie_acs_override [PCIE] Override missing PCIe ACS support for: | |
+ downstream | |
+ All downstream ports - full ACS capabilities | |
+ multifunction | |
+ All multifunction devices - multifunction ACS subset | |
+ id:nnnn:nnnn | |
+ Specific device - full ACS capabilities | |
+ Specified as vid:did (vendor/device ID) in hex | |
noioapicquirk [APIC] Disable all boot interrupt quirks. | |
Safety option to keep boot IRQs enabled. This | |
should never be necessary. | |
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c | |
index eaa003687..df3a18aa6 100644 | |
--- a/drivers/pci/quirks.c | |
+++ b/drivers/pci/quirks.c | |
@@ -3561,6 +3561,106 @@ static void quirk_no_bus_reset(struct pci_dev *dev) | |
dev->dev_flags |= PCI_DEV_FLAGS_NO_BUS_RESET; | |
} | |
+static bool acs_on_downstream; | |
+static bool acs_on_multifunction; | |
+ | |
+#define NUM_ACS_IDS 16 | |
+struct acs_on_id { | |
+ unsigned short vendor; | |
+ unsigned short device; | |
+}; | |
+static struct acs_on_id acs_on_ids[NUM_ACS_IDS]; | |
+static u8 max_acs_id; | |
+ | |
+static __init int pcie_acs_override_setup(char *p) | |
+{ | |
+ if (!p) | |
+ return -EINVAL; | |
+ | |
+ while (*p) { | |
+ if (!strncmp(p, "downstream", 10)) | |
+ acs_on_downstream = true; | |
+ if (!strncmp(p, "multifunction", 13)) | |
+ acs_on_multifunction = true; | |
+ if (!strncmp(p, "id:", 3)) { | |
+ char opt[5]; | |
+ int ret; | |
+ long val; | |
+ | |
+ if (max_acs_id >= NUM_ACS_IDS - 1) { | |
+ pr_warn("Out of PCIe ACS override slots (%d)\n", | |
+ NUM_ACS_IDS); | |
+ goto next; | |
+ } | |
+ | |
+ p += 3; | |
+ snprintf(opt, 5, "%s", p); | |
+ ret = kstrtol(opt, 16, &val); | |
+ if (ret) { | |
+ pr_warn("PCIe ACS ID parse error %d\n", ret); | |
+ goto next; | |
+ } | |
+ acs_on_ids[max_acs_id].vendor = val; | |
+ | |
+ p += strcspn(p, ":"); | |
+ if (*p != ':') { | |
+ pr_warn("PCIe ACS invalid ID\n"); | |
+ goto next; | |
+ } | |
+ | |
+ p++; | |
+ snprintf(opt, 5, "%s", p); | |
+ ret = kstrtol(opt, 16, &val); | |
+ if (ret) { | |
+ pr_warn("PCIe ACS ID parse error %d\n", ret); | |
+ goto next; | |
+ } | |
+ acs_on_ids[max_acs_id].device = val; | |
+ max_acs_id++; | |
+ } | |
+next: | |
+ p += strcspn(p, ","); | |
+ if (*p == ',') | |
+ p++; | |
+ } | |
+ | |
+ if (acs_on_downstream || acs_on_multifunction || max_acs_id) | |
+ pr_warn("Warning: PCIe ACS overrides enabled; This may allow non-IOMMU protected peer-to-peer DMA\n"); | |
+ | |
+ return 0; | |
+} | |
+early_param("pcie_acs_override", pcie_acs_override_setup); | |
+ | |
+static int pcie_acs_overrides(struct pci_dev *dev, u16 acs_flags) | |
+{ | |
+ int i; | |
+ | |
+ /* Never override ACS for legacy devices or devices with ACS caps */ | |
+ if (!pci_is_pcie(dev) || | |
+ pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ACS)) | |
+ return -ENOTTY; | |
+ | |
+ for (i = 0; i < max_acs_id; i++) | |
+ if (acs_on_ids[i].vendor == dev->vendor && | |
+ acs_on_ids[i].device == dev->device) | |
+ return 1; | |
+ | |
+ switch (pci_pcie_type(dev)) { | |
+ case PCI_EXP_TYPE_DOWNSTREAM: | |
+ case PCI_EXP_TYPE_ROOT_PORT: | |
+ if (acs_on_downstream) | |
+ return 1; | |
+ break; | |
+ case PCI_EXP_TYPE_ENDPOINT: | |
+ case PCI_EXP_TYPE_UPSTREAM: | |
+ case PCI_EXP_TYPE_LEG_END: | |
+ case PCI_EXP_TYPE_RC_END: | |
+ if (acs_on_multifunction && dev->multifunction) | |
+ return 1; | |
+ } | |
+ | |
+ return -ENOTTY; | |
+} | |
/* | |
* Some Atheros AR9xxx and QCA988x chips do not behave after a bus reset. | |
* The device will throw a Link Down error on AER-capable systems and | |
@@ -4829,6 +4929,7 @@ static const struct pci_dev_acs_enabled { | |
{ PCI_VENDOR_ID_ZHAOXIN, 0x9083, pci_quirk_mf_endpoint_acs }, | |
/* Zhaoxin Root/Downstream Ports */ | |
{ PCI_VENDOR_ID_ZHAOXIN, PCI_ANY_ID, pci_quirk_zhaoxin_pcie_ports_acs }, | |
+ { PCI_ANY_ID, PCI_ANY_ID, pcie_acs_overrides }, | |
{ 0 } | |
}; | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment